Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add protobuf compiler plugin and required dependencies for generating gRPC Java stubs #462

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

rkunds
Copy link
Member

@rkunds rkunds commented Jun 2, 2023

Add protobuf compiler plugin and required dependencies for generating gRPC Java stubs

How was this PR tested?

wpi: Local and GHCI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR! I've left some comments.

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
services/venice-server/build.gradle Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
@rkunds rkunds requested a review from sushantmane June 5, 2023 23:16
Copy link
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rkunds!

@sushantmane sushantmane merged commit 16cc06a into linkedin:main Jun 6, 2023
nisargthakkar added a commit to nisargthakkar/venice that referenced this pull request Jun 8, 2023
…s for generating gRPC Java stubs (linkedin#462)"

This reverts commit 16cc06a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants