Upgrades Finagle version to 18.12.0 #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2018 11:57
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
1 task
adleong
reviewed
Dec 15, 2018
| def read(): Future[Option[Buf]] = reader.read().handle { | ||
| case NonFatal(e) => | ||
| log.debug(e, "Error reading JSON stream") | ||
| None | ||
| } | ||
| def discard(): Unit = reader.discard() | ||
|
|
||
| def onClose: Future[StreamTermination] = closeP |
There was a problem hiding this comment.
this promise is never satisfied? why shouldn't this be a pass through to reader.onClose?
ccmtaylor
reviewed
Dec 15, 2018
| @@ -5,8 +5,7 @@ import com.fasterxml.jackson.annotation._ | |||
| import com.fasterxml.jackson.core.{JsonParser, TreeNode} | |||
| import com.fasterxml.jackson.databind.annotation.JsonDeserialize | |||
| import com.fasterxml.jackson.databind.{DeserializationContext, JsonDeserializer, JsonNode} | |||
| import com.twitter.conversions.storage._ | |||
| import com.twitter.conversions.time._ | |||
| import com.twitter.conversions.DurationOps._ | |||
There was a problem hiding this comment.
Ah, we ran into this issue too. It should be fixed in the next release: twitter/util#239
There was a problem hiding this comment.
Oh awesome, glad this was fixed. 😄
| import com.twitter.conversions.time._ | ||
| import com.twitter.finagle.{Path, Stack} | ||
| import com.twitter.conversions.StorageUnitOps._ | ||
| import com.twitter.conversions.DurationOps._ |
There was a problem hiding this comment.
Are these imports used? The issue I linked should prevent them from working...
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
|
Ah, looks like I can't merge it without @ccmtaylor's approval. I was wondering why I couldn't see the big green button haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2180
fixes #2184