Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions for integrating with Contour incomplete #6237

Closed
jroper opened this issue Jun 8, 2021 · 1 comment · Fixed by linkerd/website#1123
Closed

Instructions for integrating with Contour incomplete #6237

jroper opened this issue Jun 8, 2021 · 1 comment · Fixed by linkerd/website#1123
Labels
area/docs help wanted priority/P1 Planned for Release
Milestone
stable-2.11.0

Comments

@jroper
Copy link
Contributor

jroper commented Jun 8, 2021

With the current instructions for integrating with Contour, Contour fails to start, because linkerd blocks traffic from the Contour envoy proxy to the Contour controller manager (an xDS server, uses gRPC with mTLS to communicate) because linkerd only allows HTTP traffic (but the xDS server traffic is TLS) when in ingress mode, the following error is output in the linkerd logs:

[   484.169131s]  INFO ThreadId(01) linkerd_app_core::serve: Connection closed error=ingress-mode routing is HTTP-only

To fix this, communication with the xDS server must be excluded from going through the linkerd proxy, by adding the following annotation:

config.linkerd.io/skip-outbound-ports: 8001
@adleong
Copy link
Member

adleong commented Jun 8, 2021

Great catch, thanks @jroper! Are you interested in submitting a fix for this as a PR in the linkerd/website repo?

@olix0r olix0r added the priority/P1 Planned for Release label Jun 11, 2021
@olix0r olix0r added this to the stable-2.11.0 milestone Jun 11, 2021
alpeb added a commit to linkerd/website that referenced this issue Jul 9, 2021
@alpeb
Update Contour instructions
ae7df71 
Fixes linkerd/linkerd2#6237

- Since a few releases ago, `linkerd inject` will fail outright if
`automountServiceAccountToken` is not `true`. Reshuffled the instructions to
account for that.
- Added note about adding the
`config.linkerd.io/skip-outbound-ports: 8001` annotation when in ingress mode.
- Removed the `spec.routes.services.namespace` field from the sample
`HTTPProxy` resource, which doesn't appear in the resource API doc.
- Replaced `127.0.0.1.xip.io` with `127.0.0.1.nip.io` as the former is down.
@alpeb alpeb mentioned this issue Jul 9, 2021
Merged
cpretzer added a commit to linkerd/website that referenced this issue Jul 13, 2021
@alpeb @cpretzer
Update Contour instructions (#1123)
1a19528 
Fixes linkerd/linkerd2#6237

- Since a few releases ago, `linkerd inject` will fail outright if
`automountServiceAccountToken` is not `true`. Reshuffled the instructions to
account for that.
- Added note about adding the
`config.linkerd.io/skip-outbound-ports: 8001` annotation when in ingress mode.
- Removed the `spec.routes.services.namespace` field from the sample
`HTTPProxy` resource, which doesn't appear in the resource API doc.
- Replaced `127.0.0.1.xip.io` with `127.0.0.1.nip.io` as the former is down.

Co-authored-by: cpretzer <cpretzer@users.noreply.github.com>
cpretzer added a commit to linkerd/website that referenced this issue Jul 14, 2021
@C-Mejlak @alpeb @cpretzer
update: june meetup (#1127)
f97bea0 
* update: june meetup

- add video schema
- add featured image

Signed-off-by: Christian Mejlak <chris@mejlak.com>

* Update Contour instructions (#1123)

Fixes linkerd/linkerd2#6237

- Since a few releases ago, `linkerd inject` will fail outright if
`automountServiceAccountToken` is not `true`. Reshuffled the instructions to
account for that.
- Added note about adding the
`config.linkerd.io/skip-outbound-ports: 8001` annotation when in ingress mode.
- Removed the `spec.routes.services.namespace` field from the sample
`HTTPProxy` resource, which doesn't appear in the resource API doc.
- Replaced `127.0.0.1.xip.io` with `127.0.0.1.nip.io` as the former is down.

Co-authored-by: cpretzer <cpretzer@users.noreply.github.com>

* update: june meetup

- add video schema
- add featured image

Signed-off-by: Christian Mejlak <chris@mejlak.com>

Co-authored-by: Alejandro Pedraza <alejandro@buoyant.io>
Co-authored-by: cpretzer <cpretzer@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/docs help wanted priority/P1 Planned for Release
Projects
None yet
Milestone
stable-2.11.0
Development

Successfully merging a pull request may close this issue.

Update Contour instructions linkerd/website
3 participants
@jroper @olix0r @adleong