This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Fix getZoneIDForEndpoint to properly calculate the longest match #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was trying to find the longest match, but then confused the matching zoneID with the matching zoneName. As zoneIDs are all of the same length it would pick the last zone that had a name longer than this standard length (or the first zone, if there was never any long zone).
|
good catch! thanks a lot for the great contribution ;) |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was trying to find the longest match, but then confused the matching zoneID with the matching
zoneName. As zoneIDs are all of the same length it would pick the last zone that had a name longer than this
standard length (or the first zone, if there was never any long zone).