Skip to content

Commit

Permalink
kbuild: Don't reset timestamps in include/generated if not needed
Browse files Browse the repository at this point in the history
Use filechk to generate asm-offsets.h and bounds.h. Based on a patch by
Valdis Kletnieks.

Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Acked-By: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
  • Loading branch information
michal42 committed Mar 24, 2015
1 parent c517d83 commit 70a4fd6
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ define sed-y
s:->::; p;}"
endef

quiet_cmd_offsets = GEN $@
define cmd_offsets
# Use filechk to avoid rebuilds when a header changes, but the resulting file
# does not
define filechk_offsets
(set -e; \
echo "#ifndef $2"; \
echo "#define $2"; \
Expand All @@ -24,9 +25,9 @@ define cmd_offsets
echo " * This file was generated by Kbuild"; \
echo " */"; \
echo ""; \
sed -ne $(sed-y) $<; \
sed -ne $(sed-y); \
echo ""; \
echo "#endif" ) > $@
echo "#endif" )
endef

#####
Expand All @@ -42,9 +43,8 @@ kernel/bounds.s: kernel/bounds.c FORCE
$(Q)mkdir -p $(dir $@)
$(call if_changed_dep,cc_s_c)

$(obj)/$(bounds-file): kernel/bounds.s Kbuild
$(Q)mkdir -p $(dir $@)
$(call cmd,offsets,__LINUX_BOUNDS_H__)
$(obj)/$(bounds-file): kernel/bounds.s FORCE
$(call filechk,offsets,__LINUX_BOUNDS_H__)

#####
# 2) Generate asm-offsets.h
Expand All @@ -62,8 +62,8 @@ arch/$(SRCARCH)/kernel/asm-offsets.s: arch/$(SRCARCH)/kernel/asm-offsets.c \
$(Q)mkdir -p $(dir $@)
$(call if_changed_dep,cc_s_c)

$(obj)/$(offsets-file): arch/$(SRCARCH)/kernel/asm-offsets.s Kbuild
$(call cmd,offsets,__ASM_OFFSETS_H__)
$(obj)/$(offsets-file): arch/$(SRCARCH)/kernel/asm-offsets.s FORCE
$(call filechk,offsets,__ASM_OFFSETS_H__)

#####
# 3) Check for missing system calls
Expand Down

0 comments on commit 70a4fd6

Please sign in to comment.