Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES #174

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES #174

merged 1 commit into from
Aug 2, 2024

Conversation

dantti
Copy link
Contributor

@dantti dantti commented Jun 12, 2024 •
edited
Loading

Fixes: #121

dantti
dantti commented Jun 12, 2024
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
@dantti dantti force-pushed the dantti/rename_extra_plugins branch 2 times, most recently from 7f77ae6 to 3f5c1fb Compare June 12, 2024 21:13
TheAssassin
TheAssassin reviewed Jun 12, 2024
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
@dantti
Copy link
Contributor Author

dantti commented Jun 12, 2024

Applying your suggestion through github created a new commit, are you fine with squashing it or prefer that I do it?

@TheAssassin
Copy link
Member

Feel free to squash the changes.

TheAssassin
TheAssassin reviewed Jun 16, 2024
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
@dantti dantti force-pushed the dantti/rename_extra_plugins branch from 32afd35 to d65cb3a Compare June 16, 2024 01:24
bjorn
bjorn reviewed Jun 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/main.cpp Show resolved Hide resolved
@dantti dantti force-pushed the dantti/rename_extra_plugins branch from d65cb3a to 05727cd Compare June 18, 2024 19:45
@dantti dantti force-pushed the dantti/rename_extra_plugins branch from 05727cd to 12bd813 Compare June 19, 2024 13:15
@TheAssassin TheAssassin merged commit d23999a into linuxdeploy:master Aug 2, 2024
@TheAssassin
Copy link
Member

Thanks! And sorry for the long delay. I've been really busy lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn bjorn bjorn approved these changes

@TheAssassin TheAssassin TheAssassin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EXTRA_QT_PLUGINS is a bit misleading
3 participants
@dantti @TheAssassin @bjorn