Fix linuxdeploy log directory rename #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context, this adjustment is necessary in response to linuxdeploy/linuxdeploy@2b73a21. It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it). |
You're absolutely right about this. This was rushed a bit. It shouldn't be a big deal to use a tool like Meld and diff the old and new code, though. At any rate, @dantti please rebase this branch, then we can merge it. |
dantti
force-pushed
the
dantti/fix_linuxdeploy_log_include
branch
2 times, most recently
from
70e3e97
to
90703c8
Compare
dantti
force-pushed
the
dantti/fix_linuxdeploy_log_include
branch
from
90703c8
to
3d9d609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I needed linuxdeploy-plugin-qt that had the --exclude-libraries working I make the github workflows run on my fork and and have this issue when using a newer (+my patch) linuxdeploy submodule.