Copy v8_context_snapshot.bin to resources when deploying Qt WebEngine. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was added in Qt6.
|
Given the opportunistic approach (i.e., we copy if the file if it exists and skip it otherwise), this shouldn't break compatibility with Qt 5. Therefore, I'm willing to merge it. Let's see what the CI has to say. |
|
Thanks! |
|
@TheAssassin I was planning to use the fix made by @camilasan |
|
I'm preparing a PR at the moment. |
15 tasks
camilasan
added a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
mgallien
pushed a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
added a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
Fix #7128 #7183. See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
added a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
Fix for #7128 #7183. See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
added a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
Fix for #7128. See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
mgallien
pushed a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
Fix for #7128. See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
backportbot bot
pushed a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
Fix for #7128. See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
mgallien
pushed a commit
to nextcloud/desktop
that referenced
this pull request
Sep 25, 2024
Fix for #7128. See linuxdeploy/linuxdeploy-plugin-qt#186. Signed-off-by: Camila Ayres <hello@camilasan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was added in Qt6.
See https://doc.qt.io/qt-6/qtwebengine-deploying.html