-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong indices when the domain name contains the same TLD twice #109
Comments
@tkrissuu Thank you for reporting this issue. Nice catch! |
lipoja
added a commit
that referenced
this issue
Dec 21, 2021
lipoja
added a commit
that referenced
this issue
Dec 21, 2021
lipoja
added a commit
that referenced
this issue
Dec 21, 2021
@tkrissuu It should be fixed in v1.5.0. |
@lipoja Awesome. Thanks! That was quick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am seeing a strange behaviour when finding URLs with indices. It is triggered when the TLD is also present earlier in the domain name. In the example below ".com" appears twice. But it will also fail with e.g. "www.dk-hostmaster.dk".
To reproduce:
Output is:
('www.company.com', (8, 23))
I would have expected:
('www.company.com', (0, 15))
The text was updated successfully, but these errors were encountered: