Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile需要改进,有导致依赖不会被自动关联上的问题,导致编译出来的固件没有依赖 #60

Closed
wlshdjj opened this issue Aug 20, 2022 · 5 comments · Fixed by #65

Comments

@wlshdjj
Copy link

wlshdjj commented Aug 20, 2022

下面是需要改动的部分:
#--------------------------------------------------------------------------
include $(TOPDIR)/rules.mk

PKG_NAME:=luci-app-diskman
PKG_VERSION:=v0.2.11
PKG_RELEASE:=beta

PKG_LICENSE:=GPL-3.0-only
PKG_MAINTAINER:=lisaac https://github.com/lisaac/luci-app-diskman

PKG_CONFIG_DEPENDS:=
CONFIG_PACKAGE_$(PKG_NAME)INCLUDE_btrfs_progs
CONFIG_PACKAGE
$(PKG_NAME)INCLUDE_lsblk
CONFIG_PACKAGE
$(PKG_NAME)INCLUDE_mdadm
CONFIG_PACKAGE
$(PKG_NAME)INCLUDE_kmod_md_raid456
CONFIG_PACKAGE
$(PKG_NAME)_INCLUDE_kmod_md_linears

LUCI_TITLE:=Disk Manager interface for LuCI
LUCI_DEPENDS:=+e2fsprogs +parted +smartmontools +blkid
+PACKAGE_$(PKG_NAME)INCLUDE_btrfs_progs:btrfs-progs
+PACKAGE
$(PKG_NAME)INCLUDE_lsblk:lsblk
+PACKAGE
$(PKG_NAME)INCLUDE_mdadm:mdadm
+PACKAGE
$(PKG_NAME)INCLUDE_kmod_md_raid456:mdadm
+PACKAGE
$(PKG_NAME)INCLUDE_kmod_md_raid456:kmod-md-raid456
+PACKAGE
$(PKG_NAME)INCLUDE_kmod_md_linears:mdadm
+PACKAGE
$(PKG_NAME)_INCLUDE_kmod_md_linears:kmod-md-linear
LUCI_PKGARCH:=all
#--------------------------------------------------------------------------

@wlshdjj
Copy link
Author

wlshdjj commented Aug 20, 2022

另外原来的makefile每次编译都要强行git一次,实在无此必要,有时候git失败导致编译失败,浪费很多时间

@jjm2473
Copy link
Contributor

jjm2473 commented Feb 4, 2023

可以使用我的这个分支,改成了标准的luci makefile,不会再从git克隆 https://github.com/jjm2473/luci-app-diskman/tree/dev

@lisaac
Copy link
Owner

lisaac commented Feb 4, 2023

期待 PR

可以使用我的这个分支,改成了标准的luci makefile,不会再从git克隆 https://github.com/jjm2473/luci-app-diskman/tree/dev

@jjm2473
Copy link
Contributor

jjm2473 commented Feb 5, 2023

@lisaac 你的原始makefile这样写不是为了方便某些人单独拷贝makefile就可以编译吗?如果改成标准的makefile,那就需要加feed才能编译。不知道是不是你想要的

@lisaac
Copy link
Owner

lisaac commented Feb 13, 2023

@lisaac 你的原始makefile这样写不是为了方便某些人单独拷贝makefile就可以编译吗?如果改成标准的makefile,那就需要加feed才能编译。不知道是不是你想要的

改成标准的也行的

muink added a commit to muink/luci-app-diskman that referenced this issue Feb 25, 2023
@muink muink mentioned this issue Feb 25, 2023
muink added a commit to muink/luci-app-diskman that referenced this issue Feb 25, 2023
lisaac added a commit that referenced this issue Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants