Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors from commands which don't return success response #71

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

atugushev
Copy link
Collaborator

Fixes #70.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Base: 86.75% // Head: 86.86% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (b1ad23b) compared to base (93d5edb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   86.75%   86.86%   +0.11%     
==========================================
  Files          33       33              
  Lines        1963     1980      +17     
  Branches      226      227       +1     
==========================================
+ Hits         1703     1720      +17     
  Misses        193      193              
  Partials       67       67              
Impacted Files Coverage Δ
ansq/tcp/connection.py 66.77% <100.00%> (+0.31%) ⬆️
ansq/tcp/types/response_schemas.py 98.11% <100.00%> (+0.11%) ⬆️
tests/test_connection.py 95.31% <100.00%> (+0.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@Ivashkaization Ivashkaization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atugushev atugushev merged commit dad2e50 into list-family:master Sep 19, 2022
@atugushev atugushev deleted the fin-exc-70 branch September 19, 2022 09:41
@atugushev
Copy link
Collaborator Author

Thanks @Ivashkaization!

@atugushev atugushev added this to the 0.2.0 milestone May 30, 2023
@atugushev atugushev added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception on invalid connection.fin()
3 participants