Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log repr of incoming message only in debug mode #80

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

atugushev
Copy link
Collaborator

Resolved #74.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 87.62% // Head: 87.55% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (249070f) compared to base (70180f0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   87.62%   87.55%   -0.07%     
==========================================
  Files          33       33              
  Lines        2036     2041       +5     
  Branches      232      234       +2     
==========================================
+ Hits         1784     1787       +3     
- Misses        186      188       +2     
  Partials       66       66              
Impacted Files Coverage Δ
tests/test_utils.py 100.00% <ø> (ø)
ansq/tcp/connection.py 67.50% <100.00%> (+0.10%) ⬆️
ansq/tcp/types/response_schemas.py 94.44% <100.00%> (-3.67%) ⬇️
ansq/utils.py 86.02% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Overall I'm ok with the PR as it is now.

ansq/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@atugushev atugushev merged commit 42cd062 into list-family:master Nov 4, 2022
@atugushev atugushev deleted the 74-repr branch November 4, 2022 16:21
@atugushev
Copy link
Collaborator Author

Thanks @lig!

@atugushev atugushev added this to the 0.2.0 milestone May 30, 2023
@atugushev atugushev added the bug Something isn't working label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpreventable call to response.__repr__ in NSQConnection._parse.data
3 participants