Skip to content

Commit

Permalink
Pin Redis version (#1903)
Browse files Browse the repository at this point in the history
* chore: add event_loop fixture

* chore: pin redis versions

* chore: remove redundant fixture
  • Loading branch information
Goldziher authored Jul 1, 2023
1 parent d62df1f commit 3239692
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 11 deletions.
10 changes: 5 additions & 5 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ python-dateutil = { version = "*", optional = true }
python-jose = { version = "*", optional = true }
pytimeparse = { version = "*", optional = true }
pyyaml = "*"
redis = { version = ">=4.6.0", optional = true, extras = ["hiredis"] }
redis = { version = ">=4.4.4, <4.5.0", optional = true, extras = ["hiredis"] }
rich = { version = ">=13.0.0", optional = true }
rich-click = { version = "*", optional = true }
sqlalchemy = { version = ">=2.0.12", optional = true }
Expand Down Expand Up @@ -151,7 +151,7 @@ python-dateutil = "*"
python-dotenv = "*"
python-jose = "*"
pytimeparse = "*"
redis = "*"
redis = ">=4.4.4, <4.5.0"
rich = "*"
rich-click = "*"
sqlalchemy = ">=2.0"
Expand Down
5 changes: 1 addition & 4 deletions tests/unit/test_channels/test_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
]
)
def channels_backend(request: FixtureRequest) -> ChannelsBackend:
if "redis" in request.param:
pytest.skip("Redis tests are failing")

return cast(ChannelsBackend, request.getfixturevalue(request.param))


Expand Down Expand Up @@ -67,7 +64,7 @@ def test_plugin_dependency_signature_namespace(memory_backend: MemoryChannelsBac


@pytest.mark.flaky(reruns=5)
async def wtest_pub_sub_wait_published(channels_backend: ChannelsBackend) -> None:
async def test_pub_sub_wait_published(channels_backend: ChannelsBackend) -> None:
async with ChannelsPlugin(backend=channels_backend, channels=["something"]) as plugin:
subscriber = await plugin.subscribe("something")
await plugin.wait_published(b"foo", "something")
Expand Down

0 comments on commit 3239692

Please sign in to comment.