Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ruff #152

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Migrate to ruff #152

merged 3 commits into from
Mar 27, 2023

Conversation

JacobCoffee
Copy link
Member

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

By submitting this issue, you agree to:

Description

Migrate to ruff for linting, ci

Close Issue(s)

Closes #151

@JacobCoffee JacobCoffee self-assigned this Mar 23, 2023
@JacobCoffee JacobCoffee added the ci This is CI related label Mar 23, 2023
@JacobCoffee JacobCoffee added this to the 2.0 milestone Mar 23, 2023
JacobCoffee
JacobCoffee commented Mar 23, 2023
View reviewed changes
Copy link
Member Author

@JacobCoffee JacobCoffee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add an ignore to the PEP8 naming rule about exceptions vs

  • ignore PEP8 naming errors in class names.

@JacobCoffee JacobCoffee reopened this Mar 23, 2023
@JacobCoffee
Copy link
Member Author

JacobCoffee commented Mar 23, 2023 •
edited
Loading

astral-sh/ruff#3676

I believe I am blocked by this issue whereby ruff blasts away our noqa's.

@Goldziher
Copy link
Contributor

astral-sh/ruff#3676

I believe I am blocked by this issue whereby ruff blasts away our noqa's.

"Then we fight in the shade"

@provinzkraut provinzkraut mentioned this pull request Mar 27, 2023
Closed
4 tasks
@provinzkraut provinzkraut reopened this Mar 27, 2023
@provinzkraut provinzkraut merged commit f89fc4f into litestar-org:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provinzkraut provinzkraut provinzkraut approved these changes

Assignees

@JacobCoffee JacobCoffee

Labels
ci This is CI related
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Enhancement: Migrate to ruff
3 participants
@JacobCoffee @Goldziher @provinzkraut