Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementation of Attrs Factory #313

Merged
merged 3 commits into from
Jul 28, 2023
Merged

feat: implementation of Attrs Factory #313

merged 3 commits into from
Jul 28, 2023

Conversation

guacs
Copy link
Member

@guacs guacs commented Jul 27, 2023 •
edited by JacobCoffee
Loading

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • implementation of Attrs Factory

Close Issue(s)

@guacs guacs requested review from a team as code owners July 27, 2023 15:20
@guacs
Copy link
Member Author

guacs commented Jul 27, 2023

This does not implement parsing of the validators to construct a Constraints dictionary. The reason for this is that the validators used by attrs are all private classes which do not have a publicly documented API.

@guacs guacs changed the title Implementation of Attrs Factory feat: implementation of Attrs Factory Jul 27, 2023
Goldziher
Goldziher reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, please add an example to the docs usage section with some explanation, and a test for the example.

@guacs
Copy link
Member Author

guacs commented Jul 27, 2023

Great, please add an example to the docs usage section with some explanation, and a test for the example.

Should this be in the Declaring Factories section of the docs?

@Goldziher
Copy link
Contributor

Great, please add an example to the docs usage section with some explanation, and a test for the example.

Should this be in the Declaring Factories section of the docs?

sure

@guacs
Copy link
Member Author

guacs commented Jul 28, 2023

@Goldziher added the docs.

Goldziher
Goldziher approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Can you join our discord and ping me? @guacs

@Goldziher Goldziher merged commit 96c61ae into litestar-org:main Jul 28, 2023
14 checks passed
@guacs guacs deleted the attrs-factory branch August 3, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goldziher Goldziher Goldziher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Add AttrsFactory
2 participants
@guacs @Goldziher