Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image component - original width and height #5

Closed
wants to merge 8 commits into from
Closed

Image component - original width and height #5

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7c5006
require Internvetion Image
lpheller Nov 3, 2020
86e7aa8
Image (original) width and height
lpheller Nov 3, 2020
1d72d9f
refactor to use attribute bag
lpheller Nov 3, 2020
3d6a721
formatting
lpheller Nov 3, 2020
c76912a
string comparison
lpheller Nov 3, 2020
f8083c6
method naming
lpheller Nov 3, 2020
260fc21
test image width attribute result
lpheller Nov 3, 2020
842b0b1
more flexible intervetion image version
cbl Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
method naming
  • Loading branch information
@lpheller
lpheller committed Nov 3, 2020
commit f8083c6a803019f0dec66ff0135551eb8cd2d463
8 changes: 4 additions & 4 deletions src/Components/ImageComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,16 @@ public function __construct(
$this->conversions = $this->getMediaConversions();
$this->thumbnail = $this->makeThumbnail($image);

$this->width = ($width === 'original') ? $this->originalWidth() : $width;
$this->height = ($height === 'original') ? $this->originalHeight() : $height;
$this->width = ($width === 'original') ? $this->getOriginalWidth() : $width;
$this->height = ($height === 'original') ? $this->getOriginalHeight() : $height;
}

/**
* Get the width of the original image
*
* @return mixed
*/
public function originalWidth()
public function getOriginalWidth()
{
if (file_exists($this->image->getPath())) {
return Image::make($this->image->getPath())->width();
Expand All @@ -122,7 +122,7 @@ public function originalWidth()
*
* @return mixed
*/
public function originalHeight()
public function getOriginalHeight()
{
if (file_exists($this->image->getPath())) {
return Image::make($this->image->getPath())->height();
Expand Down