Update README.md #146
Merged
Update README.md #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dob
reviewed
Sep 29, 2017
README.md
Outdated
| @@ -45,6 +45,13 @@ The current version of Livepeer requires [ffmpeg](https://www.ffmpeg.org/). | |||
| ### geth | |||
| Livepeer requires a local Ethereum node. To set it up, follow the [Ethereum Installation Guide](https://github.com/ethereum/go-ethereum/wiki/Building-Ethereum) (We have tested with 1.6.7) | |||
|
|
|||
| ### Creating Etherium Account | |||
There was a problem hiding this comment.
Is this step necessary @ericxtang? I don't believe I've had to do it when setting up local nodes to sync with our private testnet?
There was a problem hiding this comment.
I was unable to figure out which account is being used. so I thought if a user creates an account, he will have a better understanding.
There was a problem hiding this comment.
Yeah I think it'll be useful if the user hasn't generated an account. @R-a-x, there is a mis-spelling "Ethereum" instead of "Etherium".
There was a problem hiding this comment.
@ericxtang should I correct it and generate an another pull request ?
|
|
||
| - Run `./livepeer_cli`. | ||
| * You should see a wizard launch in the command line. | ||
| * The wizard should print out `Account Eth Addr`, `Token balance`, and `Eth balance` | ||
|
|
||
| - Get some test eth from the eth faucet from [http://eth-testnet.livepeer.org/](http://eth-testnet.livepeer.org/). Make sure to use the Eth account address from above. | ||
| - Get some test eth from the eth faucet from [http://eth-testnet.livepeer.org/](http://eth-testnet.livepeer.org/). Make sure to use the Eth account address from above. Remember to add 0x as a prefix to address, if not present. |
|
You can just push another commit into this branch and it will update the
PR. Then we can merge.
…On Sat, Sep 30, 2017 at 1:54 PM, r-a-x ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#146 (comment)>:
> @@ -45,6 +45,13 @@ The current version of Livepeer requires [ffmpeg](https://www.ffmpeg.org/).
### geth
Livepeer requires a local Ethereum node. To set it up, follow the [Ethereum Installation Guide](https://github.com/ethereum/go-ethereum/wiki/Building-Ethereum) (We have tested with 1.6.7)
+### Creating Etherium Account
@ericxtang <https://github.com/ericxtang> should I correct it and
generate an another pull request ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAolXo8bjas-Dyn-FfkCqUrku9Yh3hMks5snoA5gaJpZM4PpDF5>
.
|
fixed the typo
|
added the commit. |
Merged
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the code for creating etherium account
and modified the livepeer_linux -testnet to specify account address and password