selection: Clear known sessions if none of them has good enough latency score #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy score Problem: We never cleaned the known sessions, even if all of them had too low latency score to use; example of what sometimes happens: 1) Broadcaster accumulated 8 known sessions, but all had too low latency score 2) Session refresh was not triggered because we had a lot of knows session in the pool 3) At the same time, we didn't have sessions in unknown session pool 4) Selection checked that it cannot use the known session and tried to select from unknown sessions (but the pool was empty or there were no sessions fulfilling the condition of max price or perf score)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3086 +/- ##
===================================================
- Coverage 57.41469% 57.39836% -0.01633%
===================================================
Files 92 92
Lines 15766 15767 +1
===================================================
- Hits 9052 9050 -2
- Misses 6111 6114 +3
Partials 603 603
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
victorges
approved these changes
Jun 26, 2024
| return heap.Pop(s.knownSessions).(*BroadcastSession) | ||
| // known session does not have good enough latency score, clear the heap and use unknown session | ||
| s.knownSessions = &sessHeap{} | ||
| return s.selectUnknownSession(ctx) |
There was a problem hiding this comment.
Will this repopulate the known sessions heap as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://linear.app/livepeer/issue/ENG-2051/investigate-warnings-no-orchestrators-passed-max-price-filter
Problem: We never cleaned the known sessions, even if all of them had too low latency score to use; example of what sometimes happens: