Pidfile #57
Merged
Pidfile #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dob
reviewed
Aug 17, 2017
| @@ -215,6 +234,8 @@ func main() { | |||
| glog.Infof("MediaServer Done()") | |||
| cancel() | |||
| return | |||
| case sig := <-c: | |||
| glog.Infof("Exiting Livepeer: %v", sig) | |||
There was a problem hiding this comment.
no cleanup or return statement necessary in the case of an os.Interrupt signal?
|
we do a defer os.Remove at the top. The signal catch is to make sure we
exit in the main() method instead of just terminating (in which case defer
doesn't get invoked).
…On Thu, Aug 17, 2017 at 5:32 PM, Doug Petkanics ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/livepeer/livepeer.go
<#57 (comment)>:
> @@ -215,6 +234,8 @@ func main() {
glog.Infof("MediaServer Done()")
cancel()
return
+ case sig := <-c:
+ glog.Infof("Exiting Livepeer: %v", sig)
no cleanup or return statement necessary in the case of an os.Interrupt
signal?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#57 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVGjxH_M6w88ysjA4OqsF0b-lSm52rOks5sZLFigaJpZM4O6qlr>
.
|
dob
approved these changes
Aug 17, 2017
pschroedl
pushed a commit
to pschroedl/go-livepeer
that referenced
this pull request
Aug 16, 2024
This commit ensures that the model is pre-traced when SFAST is enabled for the ImageToVideo pipeline. Without this pre-tracing the first request will be slower than a non SFAST call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.