[Fix] helpers/assertRecord: handle nullish input

Also ensure predicates return booleans.
ljharb · Mar 7, 2023 · 7131d78 · 7131d78
1 parent 30b1270
commit 7131d78
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/helpers/assertRecord.js b/helpers/assertRecord.js
@@ -21,6 +21,9 @@ var predicates = {
 			'[[Writable]]': true
 		};
 
+		if (!Desc) {
+			return false;
+		}
 		for (var key in Desc) { // eslint-disable-line
 			if (has(Desc, key) && !allowed[key]) {
 				return false;
@@ -40,7 +43,7 @@ var predicates = {
 		return has(value, '[[Iterator]]') && has(value, '[[NextMethod]]') && has(value, '[[Done]]');
 	},
 	'PromiseCapability Record': function isPromiseCapabilityRecord(value) {
-		return value
+		return !!value
 			&& has(value, '[[Resolve]]')
 			&& typeof value['[[Resolve]]'] === 'function'
 			&& has(value, '[[Reject]]')
@@ -50,7 +53,7 @@ var predicates = {
 			&& typeof value['[[Promise]]'].then === 'function';
 	},
 	'AsyncGeneratorRequest Record': function isAsyncGeneratorRequestRecord(value) {
-		return value
+		return !!value
 			&& has(value, '[[Completion]]') // TODO: confirm is a completion record
 			&& has(value, '[[Capability]]')
 			&& predicates['PromiseCapability Record'](value['[[Capability]]']);

diff --git a/test/helpers/assertRecord.js b/test/helpers/assertRecord.js
@@ -10,7 +10,7 @@ module.exports = function assertRecordTests(ES, test) {
 	test('Property Descriptor', function (t) {
 		var record = 'Property Descriptor';
 
-		forEach(v.nonUndefinedPrimitives, function (primitive) {
+		forEach(v.primitives, function (primitive) {
 			t['throws'](
 				function () { assertRecord(ES.Type, record, 'arg', primitive); },
 				TypeError,