-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aarch64 SIMD specialization #82
Conversation
7201a6f
to
c815bee
Compare
There are still failing tests on aarch64. Notably the |
Am I good to wait for the tests to be fixed before reviewing, or would you prefer a review sooner? |
Yeah, I need to find a few hours. I think I know what's wrong, just need to fix things. I'll ping you. |
@Veedrac if all goes well, CI should be green soon. I've checked that perf matches the packed_simd variant on a M2 macbook and my mobile phone (using the bootstrap trick). |
@Veedrac CI is most certainly green. I'm tempted to just bump the version, push and publish it. |
I'm going to merge this now; it's fared well in all my tests, and if there's anything wrong, we can fix it in a followup PR. |
I'm still without a good ARM CPU (but will hopefully get one, soon), but here's what I think should likely be the aarch64 intrinsics version of bytecount.
@Veedrac if you have a bit of time, I'd appreciate a review.