Skip to content

Commit

Permalink
[libc][NFC] Make all integration tests depend on the threads implemen…
Browse files Browse the repository at this point in the history
…tation.

The integration tests use the loader which sets up the main thread's
self object. So, all integration tests have to depend on the threads
implementation.
  • Loading branch information
Siva Chandra Reddy committed Jul 13, 2022
1 parent 859c189 commit 5e61b9c
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions libc/cmake/modules/LLVMLibCTestRules.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -421,13 +421,9 @@ function(add_integration_test test_name)
get_fq_target_name(${test_name}.libc fq_libc_target_name)

get_fq_deps_list(fq_deps_list ${INTEGRATION_TEST_DEPENDS})
# Add memory functions to which compilers can emit calls.
list(APPEND fq_deps_list
libc.src.string.bcmp
libc.src.string.bzero
libc.src.string.memcmp
libc.src.string.memcpy
libc.src.string.memset)
# All integration tests setup TLS area and the main thread's self object.
# So, we need to link in the threads implementation.
list(APPEND fq_deps_list libc.src.__support.threads.thread)
list(REMOVE_DUPLICATES fq_deps_list)
# TODO: Instead of gathering internal object files from entrypoints,
# collect the object files with public names of entrypoints.
Expand Down

0 comments on commit 5e61b9c

Please sign in to comment.