[clang-format] functions without argument names are treated as K&R function and cause a break after closing paren

[mydeveloperday]

Bugzilla Link	51470
Resolution	FIXED
Resolved on	Oct 11, 2021 20:29
Version	trunk
OS	Windows NT
Blocks	#51489
CC	@owenca,@tstellar
Fixed by commit(s)	4593492 f6928cf 643f2be 748f09f 4ab7fe9 c8d8248

Extended Description

bool foo(int A,Bar) override;

becoming

bool foo(int A,Bar) 
override;

This is likely related to the support for K&R that was added

https://reviews.llvm.org/D106112

The regression is resolve by

https://reviews.llvm.org/D107950 (4593492)

This is impacting the 13.0 RC branch

[owenca]

There are two follow-up commits: f6928cf and 643f2be

[tstellar]

There are two follow-up commits: f6928cf and 643f2be

Are there any more follow-ups or is this it?

[owenca]

This is it.

[tstellar]

The fix does not apply cleanly, could someone backport this and push a branch to their local github fork?

[owenca]

Can you try applying commits f6bc614 and 0fc27ef before f6928cf and 643f2be? Thanks!

[owenca]

Can you try applying commits f6bc614 and 0fc27ef before
f6928cf and 643f2be? Thanks!

I meant applying f6bc614 and 0fc27ef before 4593492, f6928cf, and 643f2be.

[owenca]

I created a 13.0.0-rc2 branch and applied the commits:
https://github.com/owenca/llvm-project/tree/13.0.0-rc2

[tstellar]

Merged:

[tstellar]

mentioned in issue #51489