Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stylelint version 15.0.0 and 16.0.0 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iansan5653
Copy link

@iansan5653 iansan5653 commented Apr 17, 2024

Adds ^15.0.0 | ^16.0.0 to the allowed peer dependencies. We have installed this in GitHub Primer's stylelint configuration (primer/stylelint-config#414) via overrides and everything has worked fine in our internal codebases, so I think this is safe to ship:

{
  "devDependencies": {
    "stylelint": "^16.3.1",
    "stylelint-css-modules-no-global-scoped-selector": "^1.0.2"
  },
  "overrides": {
    "stylelint-css-modules-no-global-scoped-selector": {
      "stylelint": "$stylelint"
    }
  }
}

cc @lmichelin

@wermanoid
Copy link

wermanoid commented Apr 22, 2024

@iansan5653 could you pleases update PR to accept v15 and v16 too? 16 works ok too

package.json Outdated Show resolved Hide resolved
Co-authored-by: Jon Rohan <jonrohan@github.com>
@iansan5653 iansan5653 changed the title Allow stylelint version 15.0.0 Allow stylelint version 15.0.0 and 16.0.0 May 9, 2024
@SergeAstapov
Copy link

Hi @lmichelin! Would you be able to look into this and release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update peer dependency for stylelint Compatibility with Stylelint v15?
4 participants