Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate send/receive chaining keys #32

Merged
merged 8 commits into from
May 13, 2023
Merged

Separate send/receive chaining keys #32

merged 8 commits into from
May 13, 2023

Conversation

ShahanaFarooqui
Copy link
Contributor

  • Removed max buffer read & write size limit introduced in PR 30.
  • Added logic for separate send/receive chaining keys. As troubleshooted and suggested by @rustyrussell.
  • Related reference PR 1079.

@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request May 13, 2023
Closed
@lnbc1QWFyb24 lnbc1QWFyb24 changed the base branch from master to develop May 13, 2023 03:01
lnbc1QWFyb24
lnbc1QWFyb24 approved these changes May 13, 2023
View reviewed changes
Copy link
Owner

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. That's a very subtle but super important bug fix. Thanks!

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit b0f5143 into lnbc1QWFyb24:develop May 13, 2023
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnbc1QWFyb24 lnbc1QWFyb24 lnbc1QWFyb24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShahanaFarooqui @lnbc1QWFyb24