Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Integration and Arduino/PlatformIO description files #1

Closed
wants to merge 8 commits into from
Closed

CI Integration and Arduino/PlatformIO description files #1

wants to merge 8 commits into from

Conversation

davidgraeff
Copy link
Contributor

This merge request is splitted in 6 commits.

  1. To make this library compatible with the Arduino/PlatformIO library managers, all source code need to be in a src subdirectory. This is also a good separation of source files and additional files.
  2. Add extern "C" to coap.h so that it can be used in c++ code.
  3. Add Arduino and PlatformIO library description files (json/ini formated files in the root of the repo)
  4. Travis configuration file for continous integration. A simple arduino application is added to test/ which is build for arduino and plattformio. Gtest is used to perform actuall unit tests, but so far there is only a simple build+socket creation test added, but it is easy to expand the test coverage now.
  5. Add travis ci status badge to the readme.
  6. Resolve name clash. You have defined an "assert" macro, but that already exists in the assert.h system header file. I renamed all coap asserts.

For continous integration with travis to work, you have to add the travis service in the preferences of this repository :)

I very much like this library, it would be great if it is added to the platformio.org and arduino library manager.

David Gräff added 6 commits February 21, 2016 15:36
Move library source files to src/ subdirectory.
fc947be 
This allows to add example/ and test/ subdirs and to have a clean separation between those files and the library source files.
Additionally this is required to make this library available as an Arduino and a PlatformIO library.
Make coap.h c++ compatible by conditionally add extern "C"
3289837
Add Arduino and PlatformIO library description files
9824a68
Add travis continous integration tests
dd415e7 
At the moment there is one simple build test for Arduino and PlatformIO called ArduinoBuildTest
and one c++/gtest based test which tests coap_mem_get, coap_mem_size, coap_mem_release, RetrieveSocket2, AllocSocket.
Add travis build/test status image to readme.md
ed76a96
Change assert(val) in coap_debug.h to assert_coap(val). The name clas…
5e5e8b0 
…hes with an official header otherwise (/usr/include/assert.h)
@lobaro
Copy link
Collaborator

lobaro commented Feb 22, 2016

Thank you, will integrate it / test it asap and post the status here. Ardruino support is nice and should be no problem since the "round" nature of the library.

Greetings Tobi

David Gräff added 2 commits February 27, 2016 13:32
Fix some compiler warnings
4071258
Add CMakeLists.txt for building the library.
38374e1 
Because there is currently no buildsystem and the test directory already
uses CMake, the library now also can be build with cmake.

This allows easy build testing with Visual Studio, QtCreator, XCode etc
and easy inclusion in other cmake based applications.
@niondir
Copy link
Member

niondir commented Mar 10, 2017

The changes are great and I try to apply them. I rebased your changes onto the current master and now the tests fail.

Some major changes are:

  • CoAP_Init signature changed
  • ifID got removed and we only use a SocketHandle_t

I'm not able to run the tests locally. I wish you could provide some help to fix the tests and maybe provide some manual how to run at least the basic_tests.cpp locally.

The rebased code with some efforts to fix the tests is on branch davidgraeff-rebased.

Any help to fix the tests is welcome.

@davidgraeff
Copy link
Contributor Author

I'm travelling the world and I'm in New Zealand at the moment, so can't really adapt the pull request in the near future unfortunately.

@niondir
Copy link
Member

niondir commented Mar 13, 2017

Okay since just the CI build is not working I might just disable the tests for now and rely on the build. There will be a chance that Arduino builds break in future until that gets fixed again.

@niondir
Copy link
Member

niondir commented Mar 15, 2017

Until I know how to move this Pull Request to another branch I just create a new Pull Request for branch davidgraeff-rebased

@niondir niondir closed this Mar 15, 2017
@niondir niondir mentioned this pull request Mar 15, 2017
Merged
@niondir
Copy link
Member

niondir commented Mar 15, 2017

Merged in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgraeff @lobaro @niondir