Skip to content

Commit

Permalink
ENH: Resolve incorrect aggregation warning (#96)
Browse files Browse the repository at this point in the history
* FIX: json NaN representation in assets/for_tests

* FIX: update unit test assets to use NaNs where missing instead of 0

* ENH: update how to handle missing merge data

* FIX: correct logger in cli

* MAINT: ignore dunder main in coverage
  • Loading branch information
loganthomas authored Nov 10, 2022
1 parent 3d701f8 commit fcbdba6
Show file tree
Hide file tree
Showing 8 changed files with 90 additions and 82 deletions.
4 changes: 4 additions & 0 deletions .coveragerc
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
[run]
omit =
setup.py

[report]
exclude_lines =
if __name__ == .__main__.:
6 changes: 3 additions & 3 deletions assets/for_tests/mock_leader_board.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"margin": {
"0": 6.61999999999999,
"1": 6.579999999999998,
"2": NaN
"2": null
},
"pts_back": {
"0": 0.0,
Expand Down Expand Up @@ -192,7 +192,7 @@
"6": 1.0,
"7": 7.0,
"8": -3.0,
"9": 0.0
"9": null
},
"PROJ_pts": {
"0": 17.9,
Expand All @@ -204,7 +204,7 @@
"6": 1.02,
"7": 6.57,
"8": 6.6,
"9": 0.0
"9": null
}
}
}
6 changes: 3 additions & 3 deletions assets/for_tests/mock_leader_board_no_actual_pts.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"margin": {
"0": 0.0,
"1": 0.0,
"2": NaN
"2": null
},
"pts_back": {
"0": 0,
Expand Down Expand Up @@ -192,7 +192,7 @@
"6": 0,
"7": 0,
"8": 0,
"9": 0
"9": null
},
"PROJ_pts": {
"0": 17.9,
Expand All @@ -204,7 +204,7 @@
"6": 1.02,
"7": 6.57,
"8": 6.6,
"9": 0.0
"9": null
}
}
}
Loading

0 comments on commit fcbdba6

Please sign in to comment.