Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ethereum submitters #17

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Support ethereum submitters #17

merged 2 commits into from
Apr 14, 2023

Conversation

gdethier
Copy link
Contributor

  • For metadata and files (links are for LLOs only and items/records are for Polkadot users only).

logion-network/logion-internal#852

benoitdevos
benoitdevos reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
I would like to discuss some points first:

pallet-logion-loc/src/lib.rs Show resolved Hide resolved
pallet-logion-loc/src/lib.rs Outdated Show resolved Hide resolved
benoitdevos
benoitdevos approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gdethier gdethier merged commit 411c2b6 into main Apr 14, 2023
@gdethier gdethier deleted the feature/ethereum-submitter branch April 14, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos