Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add certificate fees #30

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Add certificate fees #30

merged 3 commits into from
Jun 20, 2023

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented Jun 19, 2023 •
edited
Loading

  • Certificate fees are similar to storage fees
  • The rate and distribution key are part of the pallet's configuration
  • Tests are refactored in order to handle the more complex fee schemes
  • A "token issuance" field is added to collection items
  • The token issuance is set to zero for older items but must be greater than one for new items

logion-network/logion-internal#932

benoitdevos
benoitdevos approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

@gdethier gdethier force-pushed the feature/fungible-legal-fees branch from 6da76d0 to 214d5c5 Compare June 20, 2023 08:37
@gdethier gdethier changed the title Add item legal fees Add certificate fees Jun 20, 2023
@gdethier gdethier mentioned this pull request Jun 20, 2023
Merged
benoitdevos
benoitdevos approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gdethier gdethier merged commit 1d274a0 into main Jun 20, 2023
@gdethier gdethier deleted the feature/fungible-legal-fees branch June 20, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos