Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vote extrinsic #6

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Add vote extrinsic #6

merged 1 commit into from
Jan 17, 2023

Conversation

benoitdevos
Copy link
Contributor

  • Allow any LO previously recorded in a vote, to actually vote yes or no.
  • Calculate whether the vote is completed or no.
  • If the vote is completed, calculate if the vote is approved or not.

logion-network/logion-internal#725

gdethier
gdethier approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just one question/suggestion (but that can be handled later).

pallet-logion-vote/src/tests.rs Show resolved Hide resolved
@benoitdevos benoitdevos merged commit f806377 into main Jan 17, 2023
@benoitdevos benoitdevos deleted the feature/vote branch January 17, 2023 16:15
@benoitdevos benoitdevos mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier