Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and ordering, part1 #559

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Cleanup and ordering, part1 #559

merged 12 commits into from
Apr 2, 2024

Conversation

benoitdevos
Copy link
Contributor

Ordering

  • Improve page hierarchy under /src/wallet-user and /src/legal-officer

Clean-up

  • Fixed some inconsistent/deprecated naming (ContextualizedWallet to Dashboard, etc)
  • Removed a lot of unused stuff.

Protection and recovery

  • Split former trust-protection into protection and recovery.
  • Rename/remove/adapt components following simplification of protection flow.

@benoitdevos
feat: move IdentityLocRequest to loc.
6dca1bb 
logion-network/logion-internal#1197
@benoitdevos
feat: remove unused components.
179499a 
logion-network/logion-internal#1197
@benoitdevos
fix: inconsistent naming, location.
7d75b6b 
logion-network/logion-internal#1197
@benoitdevos
feat: extract paths from router; rename and move LocCreation.
c437c29 
logion-network/logion-internal#1197
@benoitdevos
feat: move idenfy results.
c18eb63 
logion-network/logion-internal#1197
@benoitdevos
feat: split trust-protection into protection and recovery.
235905f 
logion-network/logion-internal#1197
@benoitdevos
feat: move home to own subdirectory.
4e3dfa7 
logion-network/logion-internal#1197
@benoitdevos
feat: remove unused stuff.
ebe262d 
logion-network/logion-internal#1197
@benoitdevos
feat: move and rename recovery; drop reference to protection.
018eb14 
logion-network/logion-internal#1197
@benoitdevos
feat: rename ContextualizedWallet into [User|LegalOfficer]Dashboard
ebd54cd 
logion-network/logion-internal#1197
@benoitdevos
chore: remove useless stuff.
d22eb65 
logion-network/logion-internal#1197
@benoitdevos
chore: fix wording.
7ef2cee 
logion-network/logion-internal#1197
gdethier
gdethier approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks for the clean-up!

@benoitdevos benoitdevos merged commit a0971de into main Apr 2, 2024
2 checks passed
@benoitdevos benoitdevos deleted the feature/repackaging branch April 2, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier