Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wait for finalization #561

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Do not wait for finalization #561

merged 1 commit into from
Apr 18, 2024

Conversation

gdethier
Copy link
Contributor

  • Wait for in-block instead of finalization.
  • Prevents acknowledgment if no timestamp (i.e. not yet synced backend-side).
  • Close is already safe (cannot close if acknowledgement not yet synced, check in the SDK).
  • Fixes bug about estimating fees when not relevant (threw an error in LLO UI, potentially with no impact in production but visible with development mode).
  • Do not wait for transaction after successful LGNT transfer (but show a message telling there is a delay before it shows up in history). The logic in the context can be removed later.

logion-network/logion-internal#1222

Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@benoitdevos benoitdevos merged commit 6f2ec2c into main Apr 18, 2024
2 checks passed
@benoitdevos benoitdevos deleted the feature/inblock-success branch April 18, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants