Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Dont append canvas tag to DOM #150

Merged
merged 3 commits into from
May 27, 2019
Merged

refactor: Dont append canvas tag to DOM #150

merged 3 commits into from
May 27, 2019

Conversation

lokesh
Copy link
Owner

@lokesh lokesh commented May 27, 2019

Thanks @av01d for catching this.
#148

This PR also remove a console log in the demo file and a couple of unused methods on CanvasImage.

@lokesh lokesh merged commit 47cdb18 into dev May 27, 2019
@lokesh lokesh deleted the dont-append-dom branch May 27, 2019 03:40
@lokesh lokesh mentioned this pull request May 27, 2019
Closed
@lokesh lokesh mentioned this pull request Jul 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lokesh