Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensive url changes to enable app to work in a subdirectory #336

Merged
merged 2 commits into from
May 11, 2023

Conversation

dgvirtual
Copy link
Contributor

And to ensure a common standard:

  • use site_url when possible, to avoid relative paths
  • url_to instead of route_to (route_to would ignore subdirectory)
  • dynamic v static urls ('admin' to ADMIN_AREA)

(and to ensure a common standard):
- use site_url when possible, to avoid relative paths
- url_to instead of route_to
- dynamic v static urls ('admin' to ADMIN_AREA)
Copy link
Owner

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks!

@lonnieezell lonnieezell merged commit 7de4a16 into lonnieezell:develop May 11, 2023
dgvirtual added a commit to dgvirtual/Bonfire2 that referenced this pull request May 14, 2023
Broken accidentally by previous PR lonnieezell#336
dgvirtual added a commit to dgvirtual/Bonfire2 that referenced this pull request Aug 19, 2023
Broken accidentally by previous PR lonnieezell#336
dgvirtual added a commit to dgvirtual/Bonfire2 that referenced this pull request Aug 19, 2023
Broken accidentally by previous PR lonnieezell#336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants