Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Suggestions & DocBlock Comments Fixed #380

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

krishna-gujjjar
Copy link
Contributor

Fix Menu Component invalid @return type, other PHP DocBlock issue & renaming properties based on php-cs. There are no changes on the source code beside renamed some classes private properties and DocBlock.

Copy link

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Bonfire 2 developer, but my opinion is all right

@krishna-gujjjar
Copy link
Contributor Author

Here are some screenshots after all the changes.

Before After
Screenshot 2023-08-06 at 11 36 35 AM Screenshot 2023-08-06 at 1 32 29 PM

Screenshot 2023-08-06 at 8 47 54 PM

✨ Cools Suggestion with inline example preview.

@lonnieezell lonnieezell merged commit f1e99f6 into lonnieezell:develop Aug 10, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants