Add custom 2FA based on default codeigniter4/shield email 2FA #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks for this! Definitely a missed piece.
I see you're extending the action from Shieid - that's perfect. Because of that please delete an methods in this class that don' specifically need to be here for theming purposes.
Actually, IIRC the Actions use a Themeable trait that only provides $this->view() method. Would it be possible to ONLY override that method in this action to make use of the theme? Then all of the other methods wouldn't have to be duplicated which would make it safer then us having to constantly update those files when the logic changes?
kgrruz
force-pushed
the
add-2FA-shield-action
branch
from
862bdc0
to
30dbcc0
Compare
|
Done. Thank you for the explanation. If any other changes are needed, just tell me. |
kgrruz
force-pushed
the
add-2FA-shield-action
branch
2 times, most recently
from
e2cc9f9
to
a86a261
Compare
…o make use of the themes.
kgrruz
force-pushed
the
add-2FA-shield-action
branch
from
a86a261
to
5421328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom 2FA based on default codeigniter4/shield email 2FA. Just to make use of the themes.