Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter in DavQuota of SardineImpl #342

Closed
jithutintu opened this issue Dec 10, 2021 · 3 comments · Fixed by #344
Closed

Wrong parameter in DavQuota of SardineImpl #342

jithutintu opened this issue Dec 10, 2021 · 3 comments · Fixed by #344
Assignees
Labels

Comments

@jithutintu
Copy link

jithutintu commented Dec 10, 2021

Hello ,
Here in below piece of code in SardineImpl the constructor of DavQuota expect response .but the parameter passed is DavResource resource in below code.

if (resource.getStatusCode() == 200) return new DavQuota(resource);

Could you please rectify it?

Thanks

@LotharSpiegel
Copy link

See pull request: #344

@dkocher
Copy link
Collaborator

dkocher commented Mar 10, 2022

The existing code passes the required type Response and I cannot spot any error.

@LotharSpiegel
Copy link

The existing code passes in the following line:

if (resource.getStatusCode() == 200) return new DavQuota(resource);

an object of type DavResource to the constructor of DavQuota instead of sth. of type Response as needed.

@dkocher dkocher added the bug label Dec 4, 2022
@dkocher dkocher self-assigned this Dec 4, 2022
@dkocher dkocher linked a pull request Dec 4, 2022 that will close this issue
dkocher added a commit that referenced this issue Dec 4, 2022
Fix:  Wrong parameter in DavQuota of SardineImpl #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants