Race in cache fix #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rationull. Thanks so much for the PR. I am traveling through Myanmar right now and only have limited access (no laptop with me and bad internet), so can't fully test your PR. However, it looks good to me, so I'll just trust you and merge. =) |
|
Thanks @mindworker for publishing this repo with some fun exercises -- happy to help. Best wishes on your travels! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that exercise 2 "race-in-cache" doesn't actually write values into the KeyStoreCache.cache map, which means the cache size limiting doesn't work and also eliminates some of the race conditions that should be present.
Was this intentional for some reason? Figured I'd submit the trivial PR in case it's not.
Also added a test case for this exercise that will fail if the race conditions are removed but the cache map or pages list aren't updated correctly.