Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [JSON-Query] Prevent parsing string-only JSON #4425

Merged

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Jan 26, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #4423

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

@louislam louislam added this to the 1.23.12 milestone Jan 26, 2024
server/model/monitor.js Show resolved Hide resolved
server/model/monitor.js Show resolved Hide resolved
@louislam louislam force-pushed the fix/prevent-parse-string-only-json branch from c91e03c to 21e1be2 Compare January 27, 2024 19:16
@louislam louislam changed the base branch from master to 1.23.X January 27, 2024 19:17
@louislam louislam merged commit 2b8f551 into louislam:1.23.X Jan 27, 2024
@chakflying chakflying deleted the fix/prevent-parse-string-only-json branch February 1, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vaultwarden "/alive" endpoint
3 participants