Revamped Tip 18 #305
Merged
Revamped Tip 18 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed "round" to "trunc" (the former is quite different) * Restructed the tip into appropriate sections * Greatly expanded on the pros and cons
|
Perfect, |
!
|
Nice! We'll review it. |
|
@pklinger ping here! |
* Tweaked the wording in several places based on input from @pklinger. * Dropped one example for redundancy and possible confusion, folding its intent into yet more explanatory text. The general aim is to have a consistent subtext from title to final para: Yes, `~~` is cool, and probably faster than the alternative, but LOOK AT ALL THOSE SHARP EDGES!
|
Thanks for the feedback, @pklinger . I've made further adjustments that hopefully improve the tip. |
|
Thanks, I appreciate your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncating the fast way
TL;DR;
~~X == Math.trunc(X)...in certain casesUsername
gromgit
Extra
NOTE: I've changed the tip name and TL;DR for accuracy, but I did not rename the file itself.