Fix API validation for webhook DNS solver

Signed-off-by: James Munnelly <james@munnelly.eu>
lrsmith · Apr 30, 2019 · 285b864 · 285b864
1 parent 235697d
commit 285b864
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/pkg/apis/certmanager/validation/issuer.go b/pkg/apis/certmanager/validation/issuer.go
@@ -312,6 +312,16 @@ func ValidateACMEIssuerDNS01Config(iss *v1alpha1.ACMEIssuerDNS01Config, fldPath
 				}
 			}
 		}
+		if p.Webhook != nil {
+			if numProviders > 0 {
+				el = append(el, field.Forbidden(fldPath.Child("webhook"), "may not specify more than one provider type"))
+			} else {
+				numProviders++
+				if len(p.Webhook.SolverName) == 0 {
+					el = append(el, field.Required(fldPath.Child("webhook", "solverName"), "solver name must be specified"))
+				}
+			}
+		}
 		if numProviders == 0 {
 			el = append(el, field.Required(fldPath, "at least one provider must be configured"))
 		}