Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46599: Deprecate old query system behavior #1096

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

dhirving
Copy link
Contributor

Deprecate behavior from the old query system that will no longer be supported when we switch to the new implementation.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (2dda442) to head (5416af4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
python/lsst/daf/butler/registry/sql_registry.py 0.00% 1 Missing and 1 partial ⚠️
python/lsst/daf/butler/cli/cmd/commands.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   89.73%   89.72%   -0.01%     
==========================================
  Files         361      361              
  Lines       47308    47330      +22     
  Branches     5765     5771       +6     
==========================================
+ Hits        42451    42467      +16     
- Misses       3502     3511       +9     
+ Partials     1355     1352       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was also flagging globs when it shouldn't have been
Dataset materialization is believed to be unused in the wild, and we'll be removing the tests momentarily, so may as well do it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant