DM-41366: Add Docker image build for butler server #900
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 87.68% 87.67% -0.01%
==========================================
Files 276 277 +1
Lines 36326 36338 +12
Branches 7581 7583 +2
==========================================
+ Hits 31851 31858 +7
- Misses 3313 3318 +5
Partials 1162 1162
☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-41366
branch
2 times, most recently
from
7b3d8c7
to
403d76f
Compare
Dockerfile
Outdated
|
|
||
| COPY . /workdir | ||
| WORKDIR /workdir | ||
| RUN pip install --no-cache-dir . |
There was a problem hiding this comment.
Maybe add --no-deps here so it doesn't try again to install all the dependencies that we've installed via requirements.txt above? Historically we have had some weird things going on with version number matches if requirements.txt is pointing to git repos and pip is using pyproject.toml dependencies from PyPI.
compose.yml
Outdated
| ports: | ||
| - "8080:8080" | ||
| environment: | ||
| BUTLER_SERVER_BUTLER_ROOT: "/butler_root" |
There was a problem hiding this comment.
I am pondering whether BUTLER_ROOT is the right term now. This is really the URI to the butler configuration (with or without the butler.yaml).
There was a problem hiding this comment.
renamed BUTLER_SERVER_CONFIG_URI
| @@ -0,0 +1,2 @@ | |||
| uvicorn | |||
| psycopg2 | |||
There was a problem hiding this comment.
In theory pip install .[postgres] should pick up this dependency (it's listed as an optional dep in the pyproject.toml), but not if I've just told you to use --no-deps for that part above...
There was a problem hiding this comment.
The dependencies actually want to be installed in a separate step from the pip install of the application itself -- if the requirements.txt files don't change, Docker can cache the intermediate dependency image and save a few minutes on the next build.
Also the requirements will need to be pinned in future so we won't want pyproject.toml involved.
dhirving
force-pushed
the
tickets/DM-41366
branch
from
796f95e
to
84a2dc8
Compare
Checklist
doc/changes