Fix pkg-config library output for MSVC and enable Windows CI #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
reviewed
Sep 11, 2024
amyspark
force-pushed
the
use-object-for-exports
branch
from
6efd2e3
to
3a48279
Compare
lu-zero
approved these changes
Sep 12, 2024
|
The code looks good, why msvc is unhappy though? |
|
@lu-zero the pkg-config module requires |
amyspark
force-pushed
the
use-object-for-exports
branch
3 times, most recently
from
8ca5a34
to
59bff09
Compare
lu-zero
reviewed
Sep 12, 2024
amyspark
force-pushed
the
use-object-for-exports
branch
7 times, most recently
from
f9edd87
to
5d4dd45
Compare
Fixes pkg-config files being unusable for tools like Meson.
amyspark
force-pushed
the
use-object-for-exports
branch
2 times, most recently
from
cc4fa94
to
06d8643
Compare
amyspark
force-pushed
the
use-object-for-exports
branch
from
06d8643
to
2f734f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lu-zero ,
In #402 (comment) I mentioned that the pkg-config generator needed a bit more work for it to work with MSVC.
This PR converts the output of
native-static-libsto match the expected format of pkg-config (-lfoo, instead offoo.lib). I've also added the needed bit for this to be tested in CI.Let me know what you think.