Plex: fix guid lookup for X -> Plex sync #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #108 by fixing 2 issues within the guid matching for plex:
user_watcheddicts, rather than directly on the dict, where the guids seem to be located (alongsidelocationandtitle). This PR switches it to check directly against the dict itself.find_videowas attempting to iterate overseasonthe key (e.g. 1, 2, etc) rather than the list of episodes. This PR switches to match the logic for location based lookups a few lines aboveI've also added additional logging to hopefully help catch any similar issues in the future.
I haven't run this change very long yet, but the changes are minor and I have been able to sync both Jellyfin -> Plex, and Plex -> Jellyfin (where previously Jellyfin -> Plex would fail silently for me similar to what's noted in #108)
Thanks!