Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jellyfin/Emby: support marking item as partially watched #171

Merged

Conversation

awakenedhaggis
Copy link

@awakenedhaggis awakenedhaggis commented May 26, 2024

@luigi311
Copy link
Owner

luigi311 commented Jun 2, 2024

This is great to see! I've moved a lot from jellyfin to jellyfin_emby.py as emby support has been merged in to dev. Is it possible for you to rebase this and limit it so it only feeds it the json when jellyfin is calling it and not emby since i dont think that api exists in emby.

@awakenedhaggis
Copy link
Author

Hi! I don't have an emby instance to test with at the moment but it looks like there is the same endpoint. I'll set up a test instance to see how far back it goes version wise.

@awakenedhaggis awakenedhaggis force-pushed the feature/jellyfin-partial-watched branch from dc92237 to 2d4ccfe Compare June 2, 2024 20:04
- this feature uses the new endpoint introduced with 24cbd64
@awakenedhaggis awakenedhaggis force-pushed the feature/jellyfin-partial-watched branch from 2d4ccfe to 0fa2a69 Compare June 2, 2024 20:26
@luigi311
Copy link
Owner

luigi311 commented Jun 2, 2024

That sounds great! Hopefully it works there too so its working on all major server types.

@awakenedhaggis
Copy link
Author

Yeah this endpoint is working with the latest emby verion, and there are mentions of this endpoint in the emby forum at least back in 2022 so looks like it'll be very widespread

@awakenedhaggis
Copy link
Author

Updated changes:

  • edited query function to handle 204 responses from emby's /UserData endpoint
  • moved partial marking into the jellyfin_emby file

Worth noting the jellyfin_video object might have to be renamed to avoid confusion

@luigi311
Copy link
Owner

luigi311 commented Jun 2, 2024

thats great! Let me test it on my side and then ill merge it in and then fix the ci afterwards since the ci should now include more lines.

@luigi311 luigi311 merged commit 3fdcc99 into luigi311:dev Jun 2, 2024
2 of 4 checks passed
@luigi311 luigi311 changed the title Jellyfin: support marking item as partially watched Jellyfin/Emby: support marking item as partially watched Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants