Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added usa 2018 model 3 vehicle CAN (engine) to fingerprints.py [model3_stock_acc] #4

Merged

Conversation

nima2007
Copy link

@nima2007 nima2007 commented Apr 26, 2024

Same as #3 for model3_stock_acc branch

Car
USA 2018 Tesla Model 3 LR (AP2.5 Computer)

Route
b0af2fff166d80fe/00000014--34345db9f1/0 [done on model3 branch]

Test Plan

  1. Observe unsupported car message before this change
  2. Add new fingerprint to engine ECU ID based on first segment route's carFw
  3. Reboot Comma 3, Observe working OP

CarFw:

 'carFw': [{'address': 1840,
                          'brand': 'tesla',
                          'bus': 0,
                          'ecu': 'eps',
                          'fwVersion': b'TeM3_E014p10_0.0.0 (16),E014.17.00',
                          'logging': False,
                          'obdMultiplexing': True,
                          'request': [b'>\x00', b'"\xf1\x95'],
                          'responseAddress': 1848,
                          'subAddress': 0},
                         {'address': 1542,
                          'brand': 'tesla',
                          'bus': 1,
                          'ecu': 'engine',
                          'fwVersion': b'\x01\x00\x05\x18A\x00\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x000\x91',
                          'logging': False,
                          'obdMultiplexing': False,
                          'request': [b'>\x00', b'"\xf1\x81'],
                          'responseAddress': 1558,
                          'subAddress': 0}],

@nima2007 nima2007 changed the title added usa 2018 model 3 vehicle CAN (engine) to fingerprints.py added usa 2018 model 3 vehicle CAN (engine) to fingerprints.py [model3_stock_acc] Apr 26, 2024
@nima2007 nima2007 marked this pull request as ready for review April 26, 2024 02:12
Copy link

github-actions bot commented May 7, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@lukasloetkolben lukasloetkolben merged commit 2f36113 into lukasloetkolben:model3_stock_acc May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants