Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Löve standard to 11.4 #95

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

RunningDroid
Copy link

This also removes a function that was removed in 11.0 (love.window.getPixelScale) and a function that doesn't appear to exist (love.image.newCubeFaces)

This also removes a function that was removed in 11.0 (love.window.getPixelScale)
and a function that doesn't appear to exist (love.image.newCubeFaces)
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Not that I use Löve at all myself, but this looks fine.

By the way is there any reason not or projected in the future that we would need to be able to lint against different versions of the API? Or is always targeting the latest one reasonable enough for our purpose?

@RunningDroid
Copy link
Author

Personally I think it's fine to just target the latest version because people actively developing games probably target the latest version of Löve, but I only started working with Löve just the other week so I might not have enough experience to make the right call.

@alerque
Copy link
Member

alerque commented Jun 6, 2023

I think I'll just keep going ahead with this for now and if anybody using Löve decides it is an issue we can help them contribute what it would take to have versioned presets.

@alerque alerque merged commit 501cf57 into lunarmodules:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants