feat/with telemetry #165
Merged
feat/with telemetry #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahlunar
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Good start!
I think we need some tests on the telemetry package. Do we want it exported? Maybe it should be move to internal instead of pkg?
What are your thoughts on the global variables you introduced? It does make it harder to test the integration to it, right?
|
@mahlunar Yep, it is still a bit early for this pr. I agree with the internal things =D. For the global variable, this is mostly a convenience thing (think zlog.App), which I took inspiration from. These features should definitely also be tested. |
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
kjuulh
force-pushed
the
feat/with-telemetry
branch
from
b6f2b97
to
6e37669
Compare
|
@cablunar Same for this PR. |
cablunar
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial telemetry functionality