Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in exercises w05, encourage students to try Pos.moved and reflect over results #679

Merged
merged 4 commits into from
Oct 1, 2022

Conversation

snctfd
Copy link
Contributor

@snctfd snctfd commented Sep 30, 2022

This is a first draft to solve #678. Feedback welcome!

I have not yet managed to compile the compendium to ensure that this looks good.

@bjornregnell
Copy link
Member

bjornregnell commented Sep 30, 2022

Thanks!! I can merge and compile after review (currently you need old latex as installed in 20.04 or later or else allslides.tex fails). I will review this soon.

@bjornregnell
Copy link
Member

This looks great. It would be good if can add some text with explanation in the subtask solution as well?

@bjornregnell
Copy link
Member

Classes don't have methods, only objects and class instances do, strictly speaking...
Mabye change this "Reflektera över skillnaden mellan hur man anropar metoder i en klass jämfört med metoder i ett singelobjekt." into a question, such as "Hur skiljer sig anrop till metoder i singelobjekt respektive klassinstanser?"

@snctfd
Copy link
Contributor Author

snctfd commented Oct 1, 2022

Classes don't have methods, only objects and class instances do, strictly speaking...

Good catch - I was a little uncertain as to what the specific terminology should be, I've changed it in accordance with your suggestion.

I've also added an initial draft for an explanation to the solution. Remaining concerns:

  • I feel like the wording of the explanation could be improved, but after writing out several variants this was about the best I could do. Thoughts, suggestions?
  • As it is, I've put the explanation as a new SubtaskSolved, seeing as the existing TaskSolved for all of task 6 was just "Denna uppgift är laborationsförberedelse. Utvärdera dina lösningar genom egna tester i REPL.". Is this okay? Should I add some sort of context for what question my explanation is answering?
  • As I understand it, you typically put errors in \code tags. I initially tried this with my text, but as the error message I listed is quite long and starts near the end of the line, this simply caused most of the text to disappear off the screen. For now, I instead put the error message in quotes, and simply \code-tagged moved and Pos. Is there a better solution?

@bjornregnell
Copy link
Member

LGTM

@bjornregnell bjornregnell changed the title [WIP] encourage students to try Pos.moved and reflect over results in exercises, encourage students to try Pos.moved and reflect over results Oct 1, 2022
@bjornregnell bjornregnell changed the title in exercises, encourage students to try Pos.moved and reflect over results in exercises w05, encourage students to try Pos.moved and reflect over results Oct 1, 2022
@bjornregnell bjornregnell merged commit f9d8ee9 into lunduniversity:master Oct 1, 2022
@bjornregnell
Copy link
Member

I will add "[till en referens] till klassen"

@snctfd
Copy link
Contributor Author

snctfd commented Oct 1, 2022

Oh yeah, that makes sense :)

@bjornregnell
Copy link
Member

603f70d

@bjornregnell
Copy link
Member

many thanks for discovering and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants